Fix project artifact sharing. #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Embed the MR project into dependent projects by depending on the project and embedding its contents into the jar using the configuration instead of the project's jar task.
jakelandis
reviewed
Mar 18, 2020
| canBeResolved = true | ||
| } | ||
| implementation { | ||
| extendsFrom project.configurations.embedded |
There was a problem hiding this comment.
I don't think we should change the canBeResolved for the implementation configuration. See https://discuss.gradle.org/t/what-is-a-configuration-which-cant-be-directly-resolved/30721/2
In short, you should never change the canBeConsumed and canBeResolved flags of configuration you do not create.
also, it's not clear you are changing it ?
There was a problem hiding this comment.
Implementation shouldn't be affected by that at all. Only the embedded configuration is getting canBeResolved set on it. The implementation configuration just depends on it
There was a problem hiding this comment.
ok , i mis-understood how extendsFrom behaves
jbaiera
added a commit
that referenced
this pull request
May 13, 2020
Embed the MR project into dependent projects by depending on the project and embedding its contents into the jar using the configuration instead of the project's jar task.
|
Relates #1423 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a configuration to embed the contents of the
mrproject into dependentprojects' artifacts instead of using the
mrproject's jar task directly.Consolidate all projects' dependency blocks into one block for each project.